Skip to content

fix: skip polars cell in WASM ddd_tour notebook#645

Merged
paddymul merged 1 commit intomainfrom
fix/marimo-wasm-embed
Mar 21, 2026
Merged

fix: skip polars cell in WASM ddd_tour notebook#645
paddymul merged 1 commit intomainfrom
fix/marimo-wasm-embed

Conversation

@paddymul
Copy link
Copy Markdown
Collaborator

Summary

  • Replace the pl_df_with_weird_types cell in the WASM ddd_tour notebook with an empty DataFrame and explanation text
  • Polars has no WASM wheels, so that cell crashed pyodide and broke the entire notebook via marimo's dependency chain

Fixes #644

Test plan

  • Verify RTD preview build at /example_notebooks/buckaroo_ddd_tour/ loads and renders
  • Verify selecting "pl_df_with_weird_types" in the dropdown shows the explanation instead of crashing

🤖 Generated with Claude Code

The pl_df_with_weird_types cell imported polars, which has no WASM
wheels, breaking the entire notebook via marimo's dependency chain.
Replace with an empty DataFrame and an explanatory message.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

📦 TestPyPI package published

pip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.13.2.dev23384684210

or with uv:

uv pip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.13.2.dev23384684210

MCP server for Claude Code

claude mcp add buckaroo-table -- uvx --from "buckaroo[mcp]==0.13.2.dev23384684210" --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo-table

📖 Docs preview

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: da504cf438

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +296 to 300
def _():
import pandas as pd

_df = ddd.pl_df_with_weird_types_as_pandas()
_df = pd.DataFrame()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore the real dataset outside Pyodide

This cell now always returns pd.DataFrame() instead of calling ddd.pl_df_with_weird_types_as_pandas(), so marimo run docs/example-notebooks/marimo-wasm/buckaroo_ddd_tour.py shows an empty table even on a local CPython install with polars available. That breaks the local/non-WASM use case implied by the new markdown and removes the pl_df_with_weird_types example from the interactive DDD tour referenced in docs/source/articles/dastardly-dataframe-dataset.rst.

Useful? React with 👍 / 👎.

@paddymul paddymul added this pull request to the merge queue Mar 21, 2026
Merged via the queue into main with commit c57876e Mar 21, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: marimo WASM ddd_tour notebook broken — polars import crashes pyodide

1 participant