docs(plans): post-merge follow-ups for #787/#788/#789#790
Open
paddymul wants to merge 1 commit into
Open
Conversation
- ``0788-pushdown-consumer.md``: how to actually consume ``StatFunc.pushdown`` once #788 lands. Recommends the trust-the- author duck-typing path (Interp A) over a separate-registered-form approach, with a ``_pushdown_eligible_for`` hook in ``XorqStatPipeline``. Open questions + estimated scope. - ``0787-xorq-rows-first-coverage.md``: how to restore the phase-divergence assertion that the spike test had to drop on xorq. Lists four hypotheses for the xorq failure, an instrumentation recipe to disambiguate, and a load-bearing assertion form pinned to concrete length / filtered_length values rather than just dict inequality. - ``0789-analysis-klasses-traitlet.md``: the deeper fix punted by #789. ``analysis_klasses`` is a plain class attribute, not a traitlet, so observers don't fire on direct reassignment. ``add_analysis`` papers over this with a manual ``_handle_widget_change`` call. Outlines the traitlet conversion + subclass-override migration cost. Recommends deferring until a user-facing bug surfaces or a separate dataflow init refactor is in flight. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
📦 TestPyPI package publishedpip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.14.3.dev26199126641or with uv: uv pip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.14.3.dev26199126641MCP server for Claude Codeclaude mcp add buckaroo-table -- uvx --from "buckaroo[mcp]==0.14.3.dev26199126641" --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo-table📖 Docs preview🎨 Storybook preview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three planning docs capturing post-merge follow-up work for the in-flight scoped-SD / spike / pushdown PRs. No code changes — markdown only.
plans/0788-pushdown-consumer.md: how to actually consumeStatFunc.pushdownonce feat(paf): @stat(pushdown=...) declares engine push-down support #788 lands. Recommends the trust-the-author duck-typing path (Interp A) over the separate-registered-form approach, with a concrete_pushdown_eligible_forhook inXorqStatPipeline. Open questions + estimated scope.plans/0787-xorq-rows-first-coverage.md: how to restore the phase-divergence assertion the spike test had to drop on xorq — the PR body flagged this as the most important item to resolve before un-gating the spike. Four hypotheses for the xorq failure, an instrumentation recipe to disambiguate, and a load-bearing assertion form pinned to concretelength/filtered_lengthvalues rather than just dict inequality.plans/0789-analysis-klasses-traitlet.md: the deeper fix punted by feat(scoped-sd): wire cleaned_* into merged_sd + Codex P2 fix #789.analysis_klassesis a plain class attribute (not a traitlet), so observers don't fire on direct reassignment.add_analysispapers over this with a manual_handle_widget_changecall. Outlines the traitlet conversion + subclass-override migration cost. Recommends deferring until a user-facing bug surfaces or a separate dataflow-init refactor is in flight.Test plan
🤖 Generated with Claude Code