Skip to content

Prevent ephemeral deletion#269

Merged
abmargb merged 5 commits intobuddycloud:masterfrom
surevine:prevent-ephemeral-deletion
Nov 12, 2014
Merged

Prevent ephemeral deletion#269
abmargb merged 5 commits intobuddycloud:masterfrom
surevine:prevent-ephemeral-deletion

Conversation

@lloydwatkin
Copy link
Copy Markdown
Member

Prevent ephemeral node deletion. Requires all users to unsubscribe.

Otherwise errors with cancel::not-allowed.

@lloydwatkin lloydwatkin mentioned this pull request Nov 11, 2014
8 tasks
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) when pulling 15d48d2 on surevine:prevent-ephemeral-deletion into 9ebcece on buddycloud:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) when pulling 15d48d2 on surevine:prevent-ephemeral-deletion into 9ebcece on buddycloud:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) when pulling 15d48d2 on surevine:prevent-ephemeral-deletion into 9ebcece on buddycloud:master.

@abmargb
Copy link
Copy Markdown
Collaborator

abmargb commented Nov 12, 2014

LGTM. And thanks for fixing style problems as you go.

abmargb added a commit that referenced this pull request Nov 12, 2014
@abmargb abmargb merged commit 6cac1a9 into buddycloud:master Nov 12, 2014
@lloydwatkin lloydwatkin deleted the prevent-ephemeral-deletion branch November 12, 2014 09:03
@lloydwatkin
Copy link
Copy Markdown
Member Author

Yeah it makes for messy commits, but I can't seem to find a way for eclipse to format the entire project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants