Skip to content

Delete ephemeral nodes when last member leaves#273

Merged
abmargb merged 3 commits intobuddycloud:masterfrom
surevine:ephemeral-destroy
Nov 20, 2014
Merged

Delete ephemeral nodes when last member leaves#273
abmargb merged 3 commits intobuddycloud:masterfrom
surevine:ephemeral-destroy

Conversation

@lloydwatkin
Copy link
Copy Markdown
Member

  • Update code such that there can be no owners
  • Delete node if there is no remaining members

See #270

@lloydwatkin lloydwatkin mentioned this pull request Nov 18, 2014
8 tasks
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) when pulling 4806b62 on surevine:ephemeral-destroy into 6cac1a9 on buddycloud:master.

@abmargb
Copy link
Copy Markdown
Collaborator

abmargb commented Nov 20, 2014

@abmargb
Copy link
Copy Markdown
Collaborator

abmargb commented Nov 20, 2014

Besides that, everything LGTM.

@lloydwatkin
Copy link
Copy Markdown
Member Author

They'd have to be kicked out by a subscribed member so we're all good I
think?
On 20 Nov 2014 10:19, "Abmar Barros" notifications@github.com wrote:

What if a subscriber is kicked out via
https://github.com/buddycloud/buddycloud-server-java/blob/master/src/main/java/org/buddycloud/channelserver/packetprocessor/iq/namespace/pubsub/set/SubscriptionEvent.java
?


Reply to this email directly or view it on GitHub
#273 (comment)
.

@abmargb
Copy link
Copy Markdown
Collaborator

abmargb commented Nov 20, 2014

D'oh. Yes.

abmargb added a commit that referenced this pull request Nov 20, 2014
Delete ephemeral nodes when last member leaves
@abmargb abmargb merged commit b340b2c into buddycloud:master Nov 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants