Skip to content

Added unique IDs per sender#67

Merged
ashward merged 1 commit intobuddycloud:masterfrom
viv:master
Sep 2, 2013
Merged

Added unique IDs per sender#67
ashward merged 1 commit intobuddycloud:masterfrom
viv:master

Conversation

@viv
Copy link
Copy Markdown
Contributor

@viv viv commented Sep 2, 2013

Prior to this change if two clients used the same ID for a packet then the
federatedQueueManager could route the wrong packets back to a client.

Outgoing packets are now remapped to a unique ID before federating and
then remapped when the response comes back.

This fixes issue #42

Prior to this change if two clients used the same ID for a packet then the
federatedQueueManager could route the wrong packets back to a client.

Outgoing packets are now remapped to a unique ID before federating and
then remapped when the response comes back.
@imaginator
Copy link
Copy Markdown
Member

I'm liking all these bugs. Well... I'm liking that we are finding them!
Thanks Matthew.

On 2 September 2013 15:58, Matthew Vivian notifications@github.com wrote:

Prior to this change if two clients used the same ID for a packet then the
federatedQueueManager could route the wrong packets back to a client.

Outgoing packets are now remapped to a unique ID before federating and
then remapped when the response comes back.

This fixes issue #42#42

You can merge this Pull Request by running

git pull https://github.com/viv/buddycloud-server-java master

Or view, comment on, or merge it at:

#67
Commit Summary

  • Added unique IDs per sender

File Changes

Patch Links:

Simon Tennant | buddycloud.com | +49 17 8545 0880 | office hours:
goo.gl/tQgxP

ashward added a commit that referenced this pull request Sep 2, 2013
Added unique IDs per sender
@ashward ashward merged commit aa4cab3 into buddycloud:master Sep 2, 2013
@lloydwatkin lloydwatkin mentioned this pull request Sep 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants