Added unique IDs per sender#67
Merged
ashward merged 1 commit intobuddycloud:masterfrom Sep 2, 2013
Merged
Conversation
Prior to this change if two clients used the same ID for a packet then the federatedQueueManager could route the wrong packets back to a client. Outgoing packets are now remapped to a unique ID before federating and then remapped when the response comes back.
Member
|
I'm liking all these bugs. Well... I'm liking that we are finding them! On 2 September 2013 15:58, Matthew Vivian notifications@github.com wrote:
Simon Tennant | buddycloud.com | +49 17 8545 0880 | office hours: |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change if two clients used the same ID for a packet then the
federatedQueueManager could route the wrong packets back to a client.
Outgoing packets are now remapped to a unique ID before federating and
then remapped when the response comes back.
This fixes issue #42