Added device_id support via ENV variable or auto uuid values#104
Merged
budtmo merged 4 commits intobudtmo:masterfrom Jul 31, 2018
Merged
Added device_id support via ENV variable or auto uuid values#104budtmo merged 4 commits intobudtmo:masterfrom
budtmo merged 4 commits intobudtmo:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
+ Coverage 98.3% 98.34% +0.04%
==========================================
Files 2 2
Lines 118 121 +3
==========================================
+ Hits 116 119 +3
Misses 2 2
Continue to review full report at Codecov.
|
budtmo
reviewed
Jul 30, 2018
Owner
budtmo
left a comment
budtmo
left a comment
There was a problem hiding this comment.
Hi @devilankur18 ,
Thank you for the PR. it looks good to me.
Could you maybe fix a small codacy violation in this PR? so I can merge it
2 tasks
Repository owner
deleted a comment
Jul 30, 2018
budtmo
approved these changes
Jul 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of changes
Currently not able to set custom device id for emulator
Types of changes
Put an
xin the boxes that applyHow has this been tested?
While launching the docker image, passing the device_id value via environmrnt variable will launch the emulator with that mentioned device_id or an auto generate UUID will be set instead.