Allow to override emulator config from config file defined by path in… #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirkace
force-pushed
the
emulator_override_config_242
branch
from
701dbff to
64ceec2
Compare
budtmo
reviewed
Mar 11, 2025
Owner
budtmo
left a comment
budtmo
left a comment
There was a problem hiding this comment.
could we add unit test (you can add in test_emulator file)? and could we add it in readme (about how to use it)?
cli/src/constants/ENV.py
Outdated
| EMULATOR_NAME = "EMULATOR_NAME" | ||
| EMULATOR_NO_SKIN = "EMULATOR_NO_SKIN" | ||
| EMULATOR_SYS_IMG = "EMULATOR_SYS_IMG" | ||
| EMULATOR_OVERRIDE_CONFIG_PATH = "EMULATOR_OVERRIDE_CONFIG_PATH" |
Owner
There was a problem hiding this comment.
EMULATOR_CONFIG_PATH is a better name I think. what do you think?
Contributor
Author
There was a problem hiding this comment.
Sure, no problem, renamed. :-)
Owner
|
Thank you so much @jirkace for the PR. I just leaved some comments on this PR. |
jirkace
force-pushed
the
emulator_override_config_242
branch
from
64ceec2 to
e77d4ae
Compare
Contributor
Author
OK, I'll try to do it today. |
jirkace
force-pushed
the
emulator_override_config_242
branch
from
e77d4ae to
ab95b72
Compare
jirkace
force-pushed
the
emulator_override_config_242
branch
from
ab95b72 to
c8a8f0c
Compare
Contributor
Author
|
@budtmo Please, check it. |
budtmo
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… EVN
Types of changes
Put an
xin the boxes that applyPurpose of changes
#242
EMULATOR_OVERRIDE_CONFIG_PATH(eg.-e EMULATOR_OVERRIDE_CONFIG_PATH="/tmp/config.ini") and mount the file as volume (eg-v /your/path/to/config/config.ini:/tmp/config.ini) during docker run command