Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## release-1.0 #54 +/- ##
============================================
+ Coverage 98.98% 99% +0.01%
============================================
Files 2 2
Lines 99 100 +1
============================================
+ Hits 98 99 +1
Misses 1 1
Continue to review full report at Codecov.
|
Owner
|
Hi @red-avtovo , Thank you for the PR. Could you also maybe explain it in readme and update docker-compose and sample test scripts? so users know about it. and I will change the target branch to release-1.0. I just want to let you know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added application name capability to be able to get exact node from Selenium Grid.
According to Selenium implementation, selenium doesn't use application name. On other hand,
user can use this parameter in capabilities to identify node and then request it from Grid,
by adding it to desiredCapability