Skip to content

Application name#54

Closed
red-avtovo wants to merge 3 commits intobudtmo:release-1.0from
red-avtovo:master
Closed

Application name#54
red-avtovo wants to merge 3 commits intobudtmo:release-1.0from
red-avtovo:master

Conversation

@red-avtovo
Copy link
Copy Markdown
Contributor

Added application name capability to be able to get exact node from Selenium Grid.

According to Selenium implementation, selenium doesn't use application name. On other hand,
user can use this parameter in capabilities to identify node and then request it from Grid,
by adding it to desiredCapability

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 21, 2017

Codecov Report

Merging #54 into release-1.0 will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-1.0   #54      +/-   ##
============================================
+ Coverage        98.98%   99%   +0.01%     
============================================
  Files                2     2              
  Lines               99   100       +1     
============================================
+ Hits                98    99       +1     
  Misses               1     1
Impacted Files Coverage Δ
src/app.py 98.94% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeaa8c3...034e2e1. Read the comment docs.

@budtmo
Copy link
Copy Markdown
Owner

budtmo commented Dec 21, 2017

Hi @red-avtovo ,

Thank you for the PR. Could you also maybe explain it in readme and update docker-compose and sample test scripts? so users know about it. and I will change the target branch to release-1.0. I just want to let you know.

@budtmo budtmo changed the base branch from master to release-1.0 December 21, 2017 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants