Skip to content

648: Improve elements modal#661

Merged
jaX10bt merged 49 commits intobuerokratt:devfrom
IgorKrupenja:648-modal-elements
Aug 5, 2025
Merged

648: Improve elements modal#661
jaX10bt merged 49 commits intobuerokratt:devfrom
IgorKrupenja:648-modal-elements

Conversation

@IgorKrupenja
Copy link
Collaborator

@IgorKrupenja IgorKrupenja marked this pull request as ready for review August 4, 2025 11:07
@IgorKrupenja
Copy link
Collaborator Author

@1AhmedYasser The four remaining SonarCloud issues are actually bugs in SonarCloud. Without these type assertions TypeScript would be throwing errors. This code is not new too.

Copy link
Collaborator

@1AhmedYasser 1AhmedYasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IgorKrupenja IgorKrupenja marked this pull request as draft August 4, 2025 13:50
@IgorKrupenja IgorKrupenja marked this pull request as ready for review August 4, 2025 13:57
Copy link
Collaborator

@1AhmedYasser 1AhmedYasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2025

@jaX10bt jaX10bt linked an issue Aug 5, 2025 that may be closed by this pull request
12 tasks
@jaX10bt jaX10bt merged commit 6d86354 into buerokratt:dev Aug 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Elements Modal Restructure

3 participants