Skip to content

Fix for #946 and #947 bugs#950

Merged
ffrose merged 2 commits intobuerokratt:devfrom
rootcodelabs:fix/946_and_947
Mar 31, 2026
Merged

Fix for #946 and #947 bugs#950
ffrose merged 2 commits intobuerokratt:devfrom
rootcodelabs:fix/946_and_947

Conversation

@ruwinirathnamalala
Copy link
Copy Markdown
Collaborator

#946 and #947

This pull request introduces improvements to the service editing workflow, focusing on better handling of file cleanup during service renaming and enhancements to the multi-choice question payload logic. The main changes ensure that outdated files are properly deleted when a service is renamed and that payloads for multi-choice questions are generated more accurately.

File management improvements during service edits:

  • Added a step to delete old MCQ-related files by calling the file manager service before proceeding to delete all MCQ files in the edit.yml workflow.
  • Enhanced the structure update flow to check if the service name has changed, and if so, delete the old main file before proceeding with the edit.

Multi-choice question payload logic:

  • Updated the handleMultiChoiceQuestion function to more robustly generate payloads for multi-choice question buttons by extracting the root service name, ensuring payloads are correctly formed after renaming.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@ruwinirathnamalala
Copy link
Copy Markdown
Collaborator Author

ruwinirathnamalala commented Mar 30, 2026

@Thirunayan22 Sonar issues in service-builders.ts file are fixed in another PR: #942

Copy link
Copy Markdown
Collaborator

@matKlju matKlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ffrose ffrose merged commit 4d2ed49 into buerokratt:dev Mar 31, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] MCQ button payloads are not updated on service rename [BUG] Renaming MCQ service leaves stale .tmp files

3 participants