Add LogFormatContainer and LogLevelContainer for exposing the configured LogFormat and LogLevel#7
Open
Add LogFormatContainer and LogLevelContainer for exposing the configured LogFormat and LogLevel#7
LogFormatContainer and LogLevelContainer for exposing the configured LogFormat and LogLevel#7Conversation
stefanvanburen
approved these changes
Mar 23, 2026
bufdev
reviewed
Mar 23, 2026
appext/appext.go
Outdated
| return newLoggerContainer(logger) | ||
| } | ||
|
|
||
| // LogFormatContainer provides the [LogFormat] set for the [Container]. |
Member
There was a problem hiding this comment.
No other comments in this package use this form
| } | ||
|
|
||
| // LogFormatContainer provides the [LogFormat] set for the [Container]. | ||
| type LogFormatContainer interface { |
| type Container interface { | ||
| NameContainer | ||
| LoggerContainer | ||
| LogFormatContainer |
Member
There was a problem hiding this comment.
Strictly speaking, this is all a breaking change, can you explain a bit more why you need this?
Member
Author
There was a problem hiding this comment.
My use-case specifically is for rendering the report from our compiler. I'd like to pass on configurations from the CLI framework so that report.Renderer can respect color configs from the user.
doriable
changed the title
LogFormatContainer for exposing the configured LogFormatLogFormatContainer and LogLevelContainer for exposing the configured LogFormat and LogLevel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
LogFormatContainertoContainerthat exposesthe
LogFormatconfigured to the container. This allows outputthat is rendered outside of the
Loggerto use the same configs,e.g.
color.