Fix latest version resolution for GitHub enterprise#131
Merged
emcfarlane merged 7 commits intomainfrom Mar 13, 2025
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
nicksnyder
reviewed
Mar 10, 2025
src/installer.ts
Outdated
| github: InstanceType<typeof GitHub>, | ||
| inputs: Inputs, | ||
| ): InstanceType<typeof GitHub> { | ||
| const apiUrl = process.env.GITHUB_API_URL || ``; |
Member
There was a problem hiding this comment.
there isn't some API we can call to get the URL the github object will use?
Collaborator
Author
There was a problem hiding this comment.
Typescript complains with: github.request.defaults.baseUrl, but I believe that would be the way to check.
Co-authored-by: Nick Snyder <nsnyder@buf.build>
doriable
approved these changes
Mar 10, 2025
nicksnyder
approved these changes
Mar 11, 2025
Member
nicksnyder
left a comment
nicksnyder
left a comment
There was a problem hiding this comment.
Sounds like this works. @doriable can you do another code review since some stuff has changed
doriable
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the version resolution on enterprise instances by ensuing the API call is always resolved to the public GitHub instance.
Fixes #129