Merged
Conversation
This comment has been minimized.
This comment has been minimized.
pkwarren
approved these changes
May 9, 2025
nicksnyder
approved these changes
May 9, 2025
| } | ||
| } | ||
|
|
||
| // assertChecksum verifies the sha256 checksum of the buf binary. |
Member
There was a problem hiding this comment.
nonblocking nit: you have parameterized the algorithm but documented that it always uses sha256.
Merged
emcfarlane
added a commit
that referenced
this pull request
May 12, 2025
Below is the draft release notes: ## What's Changed * Add optional checksum parameter to verify binary by @emcfarlane in #169 **Full Changelog**: v1.1.1...v1.1.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new parameter
checksumto the GitHub action input to validate the sha256 hash of the installed buf binary.Closes #168