Cache ReadWriteBuckets based on absolute path in appprotoos.ResponseWriter#1124
Merged
Conversation
Contributor
|
So that failure is actually valid from a // testInsertionPointMixedPathsFail demonstrates that insertion points are only
// able to generate to the same output directory, even if the absolute path points
// to the same place.
func testInsertionPointMixedPathsFail(t *testing.T, runner command.Runner, receiverOut string, writerOut string) {
...
}So the test above SHOULD be failing because this doesn’t actually work: $ protoc -I proto proto/buf/alpha/image/v1/image.proto --insertion-point-receiver_out=insertion --insertion-point-writer_out=$(pwd)/insertionWith that said, we could just remove this test so that I'll follow-up here by just refactoring the test verifying that mixing the path format (absolute vs. relative) works, then leave another comment justifying it. |
Member
Author
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating the feasibility of #1123, I realized that our caching would not work for absolute vs relative paths. This should fix it, but there is a test failure.
From the comments on the test, I can't figure out what is going on and why this should be failing. @amckinney can you take a quick look?