LSP skip checks on build errors #4133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
doriable
approved these changes
Oct 30, 2025
stefanvanburen
approved these changes
Oct 30, 2025
Member
stefanvanburen
left a comment
stefanvanburen
left a comment
There was a problem hiding this comment.
👍 — looking again, I think we also should ditch the PublishDiagnostics as a part of update since it's done async again at the end of RunChecks, but can do that separately if you want.
(It might also be worthwhile for us to consolidate some of these "helper" methods into Update if they aren't used elsewhere; it looks like both RefreshIR and RunChecks have no other callsites now that we don't publish progress, and we should be able to unexport a lot of the *file methods as well.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids attempting to run the checks if the IR fails with a diagnostic of level error (ICE/Error).