Add links in docs for predeclared types, remote dependencies, and WKTs #4137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
emcfarlane
reviewed
Nov 3, 2025
private/buf/buflsp/symbol.go
Outdated
| } | ||
|
|
||
| func getCommentsFromDef(def ast.DeclDef) string { | ||
| func (s *symbol) getComments(def ast.DeclDef) string { |
Contributor
There was a problem hiding this comment.
This func signature is a bit odd because it presumes that the def must be the same symbol?
Member
Author
There was a problem hiding this comment.
Yeah... I refactored this to be a little bit clearer, hopefully, let me know what you think!
private/buf/buflsp/symbol.go
Outdated
Comment on lines
388
to
389
| components := strings.Split(bsrTooltip, ".") | ||
| bsrTooltip = strings.Join(components[:len(components)-1], ".") |
Contributor
There was a problem hiding this comment.
Don't need the string manipulation if you keep the type as the ir.FullName, then bsrTooltip.Parent().
private/buf/buflsp/symbol.go
Outdated
| )) | ||
| } | ||
| } | ||
| return strings.Join(comments, "") |
Contributor
There was a problem hiding this comment.
Maybe a strings.Builder here would be better?
emcfarlane
reviewed
Nov 3, 2025
emcfarlane
approved these changes
Nov 3, 2025
doriable
added a commit
that referenced
this pull request
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the links back for predeclared types, remote deps,
and WKTs in the LSP doc hovers.