Check for existing modules before attempting to create new ones#4189
Merged
Check for existing modules before attempting to create new ones#4189
Conversation
This changes the logic to first check the modules before attempting to create. This is because if a module already exists, we should not bother to attempt to create it. This also allows users that have pre-existing user-owned modules on servers that now disallow creating new user-owned modules to continue pushing to their modules.
…push-precondition
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
emcfarlane
approved these changes
Nov 25, 2025
Co-authored-by: Edward McFarlane <3036610+emcfarlane@users.noreply.github.com>
emcfarlane
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a fix to check modules first, before attempting
to create the modules when the
--createflag is set forbuf push.This is because if a module already exists, we shouldn't bother to
attempt to create it, and we should allow users to continue pushing
to it.
This also allows users that have pre-existing user-owned modules
on registries that now disallow creating new user-owned modules
to continue to push to their modules.
Fixes #4157