Conversation
Originally in #4361, but we need to add our typical version checks and testing. Ref: https://github.com/protocolbuffers/protobuf/releases/tag/v34.0 Ref: protocolbuffers/protobuf#15633 Supersedes #4361.
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
|
@doriable had mentioned having
And it basically one-shotted this, although it also bumped the
which caused it to revert the Makefile changes, and now we're here. (I don't see any obvious integration testing involving calling |
|
So the answer is yes and no, lol ^^" Basically, |
doriable
left a comment
There was a problem hiding this comment.
We can bump the PROTOC_VERSION for wkts, etc. as a follow-up, this looks good to me!
Originally in #4361, but we need to add our typical version checks and testing.
Ref: https://github.com/protocolbuffers/protobuf/releases/tag/v34.0
Ref: protocolbuffers/protobuf#15633
Supersedes #4361.