Skip to content

Add support for --rbs_out#4382

Merged
stefanvanburen merged 1 commit intomainfrom
svanburen/rbs
Mar 10, 2026
Merged

Add support for --rbs_out#4382
stefanvanburen merged 1 commit intomainfrom
svanburen/rbs

Conversation

@stefanvanburen
Copy link
Copy Markdown
Member

Originally in #4361, but we need to add our typical version checks and testing.

Ref: https://github.com/protocolbuffers/protobuf/releases/tag/v34.0
Ref: protocolbuffers/protobuf#15633

Supersedes #4361.

Originally in #4361, but we need to add our typical version checks and
testing.

Ref: https://github.com/protocolbuffers/protobuf/releases/tag/v34.0
Ref: protocolbuffers/protobuf#15633

Supersedes #4361.
@github-actions
Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 10, 2026, 6:51 PM

@stefanvanburen
Copy link
Copy Markdown
Member Author

@doriable had mentioned having claude take a look at this; my prompt was:

look at gh pr view 4361; I think we want to support rbs_out, but first we need to upgrade the version of protoc we're testing (maybe this is in the Makefile somewhere)? Can we do that so we make sure we're testing it?

And it basically one-shotted this, although it also bumped the PROTOC_VERSION in the Makefile, which I thought about more and didn't think was necessary, so I followed up with:

do we actually need to bump the PROTOC_VERSION for this? do tests fail without it?

which caused it to revert the Makefile changes, and now we're here. (I don't see any obvious integration testing involving calling protoc with these args, so unless I'm missing something this should be how the others work and are tested?)

@stefanvanburen stefanvanburen marked this pull request as ready for review March 10, 2026 18:56
@doriable
Copy link
Copy Markdown
Member

So the answer is yes and no, lol ^^"

Basically, PROTOC_VERSION ensures that this is the protoc version used when developing in bufbuild/buf through make and it also updates the WKTs. So in this case, we should update this version if we plan on writing tests for it, but it's not strictly necessary to update this version to support the features from the latest protoc (since it would invoke the Ruby codegen through the user's local protoc as a codegen plugin, effectively).

Copy link
Copy Markdown
Member

@doriable doriable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can bump the PROTOC_VERSION for wkts, etc. as a follow-up, this looks good to me!

@stefanvanburen stefanvanburen merged commit a85bfd8 into main Mar 10, 2026
12 checks passed
@stefanvanburen stefanvanburen deleted the svanburen/rbs branch March 10, 2026 19:27
stefanvanburen added a commit that referenced this pull request Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants