Skip to content

Add documentation links to LSP CEL hover#4385

Merged
stefanvanburen merged 2 commits intomainfrom
svanburen/add-cel-hover-doc-links
Mar 11, 2026
Merged

Add documentation links to LSP CEL hover#4385
stefanvanburen merged 2 commits intomainfrom
svanburen/add-cel-hover-doc-links

Conversation

@stefanvanburen
Copy link
Copy Markdown
Member

Similar to how we add links for protobuf hover docs to <protobuf.com> or <buf.build>, this adds relevant links for the various CEL functions/operators/etc. to <celbyexample.com> or <protovalidate.com>.

Similar to how we add links for protobuf hover docs to <protobuf.com> or
<buf.build>, this adds relevant links for the various CEL
functions/operators/etc. to <celbyexample.com> or <protovalidate.com>.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 11, 2026

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 11, 2026, 4:41 PM

@stefanvanburen
Copy link
Copy Markdown
Member Author

Double-checked these links with lychee, the one failure is just an unrelated test link:

$ lychee private/buf/buflsp/hover_cel_test.go
39/39 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links                                                                                                                                                                                        [WARN] lychee detected 1 redirect. You might want to consider replacing redirecting URLs with the resolved URLs. Run lychee in verbose mode (-v/--verbose) to see details about the redirections.
Issues found in 1 input. Find details below.

[private/buf/buflsp/hover_cel_test.go]:
     [404] https://issuer.cel.dev/ | Rejected status code: 404 Not Found (configurable with "accept" option)

🔍 39 Total (in 1s) ✅ 31 OK 🚫 1 Error 👻 6 Excluded 🔀 1 Redirects

@stefanvanburen
Copy link
Copy Markdown
Member Author

In VS Code:

image image

@stefanvanburen stefanvanburen marked this pull request as ready for review March 11, 2026 14:49
@stefanvanburen stefanvanburen merged commit e6a261d into main Mar 11, 2026
10 checks passed
@stefanvanburen stefanvanburen deleted the svanburen/add-cel-hover-doc-links branch March 11, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants