Conversation
Starting in Go 1.24, sha3 is now part of the stdlib. Switch to it instead of consuming via x/crypto.
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
pkwarren
commented
Apr 13, 2026
| shakeHash := sha3.NewShake256() | ||
| // TODO FUTURE: remove in the future, this should have no effect | ||
| shakeHash.Reset() | ||
| shakeHash := sha3.NewSHAKE256() |
Member
Author
There was a problem hiding this comment.
The x/crypto one wraps this implementation from the stdlib.
| func NewDigestForContent(reader io.Reader) (Digest, error) { | ||
| shakeHash := sha3.NewShake256() | ||
| // TODO FUTURE: remove in the future, this should have no effect | ||
| shakeHash.Reset() |
Member
Author
There was a problem hiding this comment.
Wasn't sure why this was there since we were creating it just before.
stefanvanburen
approved these changes
Apr 13, 2026
doriable
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting in Go 1.24, sha3 is now part of the stdlib. Switch to it instead of consuming via x/crypto.