Deprecate compression formats and add compression option#69
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 70.17% 70.20% +0.02%
==========================================
Files 150 150
Lines 8050 8084 +34
==========================================
+ Hits 5649 5675 +26
- Misses 1806 1812 +6
- Partials 595 597 +2
Continue to review full report at Codecov.
|
Monirul1
pushed a commit
to Monirul1/buf
that referenced
this pull request
Apr 30, 2023
stefanvanburen
added a commit
that referenced
this pull request
Feb 20, 2026
It looks like we dropped this out of the zap logs, way back in #69. @emcfarlane correctly ported the lack of a timestamp over to slog in #3844. This probably made sense when `buf` was running fairly quick CLI commands, but now that we have various server processes running from `buf`, it makes sense to add a timestamp for the various logs being emitted. I specifically wanted this when debugging `buf lsp serve`. We _could_ just make this optional (only for certain commands), but this feels fairly uncontroversial.
stefanvanburen
added a commit
that referenced
this pull request
Feb 20, 2026
It looks like we dropped this out of the zap logs, way back in #69. @emcfarlane correctly ported the lack of a timestamp over to slog in #3844. This probably made sense when `buf` was running fairly quick CLI commands, but now that we have various server processes running from `buf`, it makes sense to add a timestamp for the various logs being emitted. I specifically wanted this when debugging `buf lsp serve`. We _could_ just make this optional (only for certain commands), but this feels fairly uncontroversial.
stefanvanburen
added a commit
that referenced
this pull request
Feb 25, 2026
It looks like we dropped this out of the zap logs, way back in #69. @emcfarlane correctly ported the lack of a timestamp over to slog in #3844. This probably made sense when `buf` was running fairly quick CLI commands, but now that we have various server processes running from `buf`, it makes sense to add a timestamp for the various logs being emitted. I specifically wanted this when debugging `buf lsp serve`. We _could_ just make this optional (only for certain commands), but this feels fairly uncontroversial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.