Add logic balancing for logical and/or#130
Merged
hudlow merged 6 commits intobufbuild:mainfrom Aug 25, 2025
Merged
Conversation
|
|
|
@jafaircl thanks a bunch for the work here! Do you think it might be possible to just pull this into the builder so it's not adding stuff into the grammar file? |
Contributor
Author
|
@hudlow does that work? |
hudlow
reviewed
Jun 15, 2025
|
In general, I am not sure whether I think this should actually be the only (or even default) option, but I do like that it brings additional conformance with the default behavior of the flagship parser. I'd be okay with it as is, but perhaps @timostamm or @Alfus feel otherwise? |
hudlow
approved these changes
Jun 15, 2025
srikrsna-buf
force-pushed
the
logic-balancing
branch
from
f197225 to
a15a661
Compare
hudlow
reviewed
Aug 22, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds logic balancing for logical and/or expressions