Simplify, fix, and add tests for timestamp and duration handling #245
+461
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudlow
commented
Dec 23, 2025
| */ | ||
| export function parseDuration(str: string): Duration { | ||
| // The regex grouping the number and the unit is: | ||
| const re = /([-+]?(?:\d+|\d+\.\d*|\d*\.\d+))(ns|us|µs|ms|s|m|h)/; |
Collaborator
Author
There was a problem hiding this comment.
This was completely wrong — duration strings can't have signs except at the very beginning.
srikrsna-buf
approved these changes
Dec 23, 2025
hudlow
commented
Dec 23, 2025
Comment on lines
-27
to
-28
| assert.equal(actual.seconds, -1n); | ||
| assert.equal(actual.nanos, 999999999); |
Collaborator
Author
There was a problem hiding this comment.
Wrong! Signs are always supposed to match.
hudlow
commented
Dec 23, 2025
Comment on lines
-30
to
-33
| actual = createDuration(0n, -999999999); | ||
| assert.ok(isMessage(actual, DurationSchema)); | ||
| assert.equal(actual.seconds, -1n); | ||
| assert.equal(actual.nanos, 1); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peeled out of #244 for easier review — also fixes some additional bugs that will ostensibly be covered in new conformance tests.