Guarantee that run() never throws an error#283
Merged
srikrsna-buf merged 1 commit intomainfrom Mar 18, 2026
Merged
Conversation
|
|
This patch modifies run() to convert any thrown value to a returned CelError, and updates the doc comment to guarantee the function will never throw. It also updates the parse() doc comment to document that that function does throw on parse errors.
davidflanagan
force-pushed
the
dflanagan/dont-throw-from-run
branch
from
ccbf2a8 to
568b138
Compare
srikrsna-buf
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch modifies run() to convert any thrown value to a returned CelError, and updates the doc comment to guarantee the function will never throw. It also updates the parse() doc comment to document that that function does throw on parse errors.
Without this patch, callers have to both check the return value of run() and enclose the call in a try/catch block. With the patch it is enough to just check the return value.