Add GitHub publish workflow with trusted publishing#294
Merged
ajeetdsouza merged 15 commits intomainfrom May 6, 2026
Merged
Conversation
This replaces the npm "release" script with discrete workflow steps in publish.yaml. The workflow calling npm, npm calling a node script, and the node script calling npm again seemed a bit much. This peels off one layer of the onion. This change also allows us to reuse scripts/gh-diffcheck.js instead of reimplementing the same check in release.js.
timostamm
reviewed
May 5, 2026
…nto-discrete-steps Split publish workflow into discrete steps
Fix set-workspace-version.js
timostamm
reviewed
May 6, 2026
Member
timostamm
left a comment
There was a problem hiding this comment.
This looks neat to me. Just a couple of nits, see below.
Can you update the PR title and add a description? PRs are linked in the release notes - they are our changelog. So a self-explanatory title and a description with details is generally useful for our users. The key change we're making here is to adopt trusted publishing, which is a significant security enhancement.
This reverts commit d30b4c3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a GitHub Actions workflow to publish to npm. This uses trusted publishing to attach provenance attestations to packages, allowing users to verify their authenticity.