Skip to content

Fix types for bytes fields#13

Merged
srikrsna-buf merged 1 commit intomainfrom
sk/schema/bytes
May 22, 2023
Merged

Fix types for bytes fields#13
srikrsna-buf merged 1 commit intomainfrom
sk/schema/bytes

Conversation

@srikrsna-buf
Copy link
Member

bytes are represented using Uint8Array which is an object and hence it was being treated as one. This checks for it explicitly.

@srikrsna-buf srikrsna-buf requested a review from jhump May 22, 2023 05:07
@srikrsna-buf srikrsna-buf merged commit aaa9f2d into main May 22, 2023
@srikrsna-buf srikrsna-buf deleted the sk/schema/bytes branch May 22, 2023 14:56
@srikrsna-buf srikrsna-buf mentioned this pull request Oct 5, 2023
srikrsna-buf added a commit that referenced this pull request Oct 6, 2023
## What's Changed

Add experimental gateway support exported via a sub path export
(`/gateway`). With this users can run the Knit gateway in JS
environments like node and the browser!

NOTE: This is not well tested and users should rely on the [standalone
gateway](https://www.npmjs.com/package/@bufbuild/knitgateway)

### Bug fixes

* Fix types for `bytes` fields by @srikrsna-buf in
#13

**Full Changelog**:
v0.0.2...v0.0.3
jhump pushed a commit that referenced this pull request Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants