Skip to content

Switch to compiled golangci-lint binary#197

Merged
pkwarren merged 1 commit intomainfrom
pkw/golangci-lint-binary
Jan 27, 2025
Merged

Switch to compiled golangci-lint binary#197
pkwarren merged 1 commit intomainfrom
pkw/golangci-lint-binary

Conversation

@pkwarren
Copy link
Member

As part of CI builds, we're regularly seeing ~35s to download and compile golangci-lint. Switch to the precompiled version to see if this helps speed up builds.

As part of CI builds, we're regularly seeing ~35s to download and
compile golangci-lint. Switch to the precompiled version to see if this
helps speed up builds.
@pkwarren pkwarren merged commit 2993565 into main Jan 27, 2025
4 checks passed
@pkwarren pkwarren deleted the pkw/golangci-lint-binary branch January 27, 2025 20:08
stefanvanburen added a commit that referenced this pull request Feb 11, 2026
We probably only need to bump these on major go versions, but this just
brings back the treatment we previously had for `golangci-lint` when we
would `go install` it. Otherwise, these tools may not understand new go
versions when they're compiled with old go versions.

Ref: #197
stefanvanburen added a commit that referenced this pull request Feb 11, 2026
We probably only need to bump these on major go versions, but this just
brings back the treatment we previously had for `golangci-lint` when we
would `go install` it. Otherwise, these tools may not understand new go
versions when they're compiled with old go versions.

Ref: #197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants