Skip to content

Update dependencies and regenerate code#845

Merged
pkwarren merged 1 commit intomainfrom
pkw/update-deps
Jan 27, 2025
Merged

Update dependencies and regenerate code#845
pkwarren merged 1 commit intomainfrom
pkw/update-deps

Conversation

@pkwarren
Copy link
Member

No description provided.

@pkwarren pkwarren requested a review from unmultimedio January 27, 2025 16:34
@github-actions
Copy link

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJan 27, 2025, 4:34 PM

state protoimpl.MessageState `protogen:"opaque.v1"`
xxx_hidden_ModuleName string `protobuf:"bytes,1,opt,name=module_name,json=moduleName,proto3" json:"module_name,omitempty"`
xxx_hidden_LatestReference string `protobuf:"bytes,2,opt,name=latest_reference,json=latestReference,proto3" json:"latest_reference,omitempty"`
xxx_hidden_ModuleName string `protobuf:"bytes,1,opt,name=module_name,json=moduleName,proto3"`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@unmultimedio - I don't think this will affect consumers but just FYI.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it won't, it's a missing piece of work they had from the opaque API: golang/protobuf#1658

// global state file at the root sync directory.
type GlobalState struct {
state protoimpl.MessageState `protogen:"opaque.v1"`
xxx_hidden_Modules *[]*GlobalStateReference `protobuf:"bytes,1,rep,name=modules,proto3" json:"modules,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
reflect "reflect"
unsafe "unsafe"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

@pkwarren pkwarren merged commit 57d1b3e into main Jan 27, 2025
5 checks passed
@pkwarren pkwarren deleted the pkw/update-deps branch January 27, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants