Skip to content

Add protoc v25.6 plugins#1747

Merged
pkwarren merged 1 commit intomainfrom
pkw/backfill-protoc-25.6-jvm-plugins
Mar 7, 2025
Merged

Add protoc v25.6 plugins#1747
pkwarren merged 1 commit intomainfrom
pkw/backfill-protoc-25.6-jvm-plugins

Conversation

@pkwarren
Copy link
Member

@pkwarren pkwarren commented Mar 7, 2025

The protobuf 26.x release broke compatibility for C++, Java, Kotlin, PHP, Python, and Ruby. Most users have upgraded by now, however it may take some time for Java/Kotlin libraries and ecosystem to be updated to support the latest protobuf-java runtime.

Backfill v25.6 which is the latest release on the 25.x line. This also includes a security fix for the Java runtime in GHSA-735f-pc8j-v9w8.

Fixes #1746.

The protobuf 26.x release broke compatibility for C++, Java, Kotlin,
PHP, Python, and Ruby. Most users have upgraded by now, however
it may take some time for Java/Kotlin libraries and ecosystem to be
updated to support the latest protobuf-java runtime.

Backfill v25.6 which is the latest release on the 25.x line. This also
includes a security fix for the Java runtime in GHSA-735f-pc8j-v9w8.

Fixes #1746.
@pkwarren pkwarren requested a review from mfridman March 7, 2025 00:59
Copy link
Member Author

@pkwarren pkwarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The procedure I used to create these was to run the fetcher command (patched locally) to target v25.6. This copied the latest best practices from our newest plugin back to this release. This also makes new functionality like csharp gen SDKs available to this release.

The builds however failed. We needed to further set the USE_BAZEL_VERSION env var as the latest release of protoc pins Bazel, but earlier versions didn't.

Then I compared v25.3 to v25.6 of each plugin, copying over fixes to metadata in buf.plugin.yaml. We also had patched a few plugins that were incorrectly advertising support for editions before they supported them.

@mfridman When reviewing take a close look at buf.plugin.yaml for each plugin. I believe everything is correct but it is worth double checking.

@mfridman
Copy link
Member

mfridman commented Mar 7, 2025

Okay, I'll take a closer pass at this first thing tomorrow morning.

@pkwarren pkwarren merged commit 5545cc3 into main Mar 7, 2025
5 checks passed
@pkwarren pkwarren deleted the pkw/backfill-protoc-25.6-jvm-plugins branch March 7, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v25.6 Protobuf packages for Java/Kotlin

2 participants