Merged
Conversation
Contributor
Author
Test script
#!/usr/bin/env bash
set -euo pipefail
# Pick any ref with known plugin changes. Default: the commit before
# connectrpc/go + connectrpc/gosimple were updated.
BASE_REF="${1:-4950ddf0~1}"
echo "==> Base ref: $BASE_REF"
echo
echo "==> changed-plugins output (space-separated):"
go run ./internal/cmd/changed-plugins --base-ref "$BASE_REF" | tr ' ' '\n' | sort
echo
echo "==> Unique plugin dirs touched (git cross-check):"
git diff --name-only "$BASE_REF" HEAD \
| { grep '^plugins/' || true; } \
| awk -F/ 'NF>=4 {print $2"/"$3":"$4}' \
| sort -u
Produces output: bash .test-changed-plugins.sh
==> Base ref: 4950ddf0~1
==> changed-plugins output (space-separated):
2026/04/22 12:25:48 including plugin: plugins/connectrpc/go/v1.19.2/buf.plugin.yaml
2026/04/22 12:25:48 including plugin: plugins/connectrpc/gosimple/v1.19.2/buf.plugin.yaml
connectrpc/go:v1.19.2
connectrpc/gosimple:v1.19.2
==> Unique plugin dirs touched (git cross-check):
connectrpc/go:v1.19.2
connectrpc/gosimple:v1.19.2 |
pkwarren
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
changed-pluginsfrom the standardflagpackage toappcmd.Command, consistent with other commands in the repoBASE_REF,INCLUDE_TESTDATA) fromplugin.FilterByBaseRefDiff— parameters are now passed explicitly--base-ref(required),--dir(default.), and--include-testdataflags to the commandci.ymlandpr.ymlto pass flags inline instead of injecting env vars