Upgrade repository#141
Merged
stefanvanburen merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
* Bump Go version to 1.25.6 * Bump golangci-lint version and fix new lints * Bump copyright year * Bump buf version Ref: bufbuild/standard-go#6
stefanvanburen
commented
Apr 21, 2026
| // Split the param into key and value. | ||
| pos := strings.Index(param, "=") | ||
| if pos == -1 { | ||
| key, value, ok := strings.Cut(param, "=") |
Member
Author
There was a problem hiding this comment.
flagged by modernizer
stefanvanburen
commented
Apr 21, 2026
| for _, pathPart := range path { | ||
| newType += "." + pathPart | ||
| } | ||
| newType := strings.Join(append([]string{newRef}, path...), ".") |
Member
Author
There was a problem hiding this comment.
originally this wanted to flip to using a StringBuilder, but just simplified.
stefanvanburen
commented
Apr 21, 2026
| module github.com/bufbuild/protoschema-plugins | ||
|
|
||
| go 1.24.0 | ||
| go 1.25.6 |
Member
Author
There was a problem hiding this comment.
AFAIK this isn't a library and is only consumed as executable plugins; maybe we could bump to 1.26 and ditch the compatibility dance in CI?
Member
Author
There was a problem hiding this comment.
Fair, perhaps that was some of the original intent. Leaving for now.
emcfarlane
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: bufbuild/standard-go#6