Merged
Conversation
|
I think - but am not 100% sure - that the module proxy only re-parses the go.mod file when you cut a new release. Even if you retract all previous versions, you'll still have live docs for the new release. My memories of this are a bit hazy, but I think we need to proactively retract the version we're about to tag and release (I assume that'll be This system is...not user-friendly. |
Member
Author
|
Added the next version we'd release for this. Hopefully this does the trick 🤞🏽 |
akshayjshah
approved these changes
Jun 1, 2023
pkwarren
pushed a commit
that referenced
this pull request
Jul 18, 2023
igor-tsiglyar
pushed a commit
to igor-tsiglyar/protovalidate
that referenced
this pull request
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the brief stint of the PGV repository being renamed to
protovalidate, the Go module proxy has become a bit confused about this module. We should be able to correct the proxy (and potentially pkg.go.dev documentation) by creating the module directly and retracting all previous versions reported here:$ curl https://proxy.golang.org/github.com/bufbuild/protovalidate/@v/list # all the versions retracted in this go.mod patchThe current version reported by the proxy is v0.1.5, so this should work according to the retract documentation.
$ curl https://proxy.golang.org/github.com/bufbuild/protovalidate/@latest {"Version":"v0.1.5","Time":"2023-06-01T18:26:24Z","Origin":{"VCS":"git","URL":"https://github.com/bufbuild/protovalidate","Ref":"refs/tags/v0.1.5","Hash":"9c8e723aa8d7d34c72701585e3da2323203d4e85"}}%