Skip to content

Retract erroneous go module versions#11

Merged
rodaine merged 5 commits intomainfrom
rodaine/retract-erroneous-go-module-versions
Jun 1, 2023
Merged

Retract erroneous go module versions#11
rodaine merged 5 commits intomainfrom
rodaine/retract-erroneous-go-module-versions

Conversation

@rodaine
Copy link
Member

@rodaine rodaine commented Jun 1, 2023

From the brief stint of the PGV repository being renamed to protovalidate, the Go module proxy has become a bit confused about this module. We should be able to correct the proxy (and potentially pkg.go.dev documentation) by creating the module directly and retracting all previous versions reported here:

$ curl https://proxy.golang.org/github.com/bufbuild/protovalidate/@v/list
# all the versions retracted in this go.mod patch

The current version reported by the proxy is v0.1.5, so this should work according to the retract documentation.

$ curl https://proxy.golang.org/github.com/bufbuild/protovalidate/@latest 
{"Version":"v0.1.5","Time":"2023-06-01T18:26:24Z","Origin":{"VCS":"git","URL":"https://github.com/bufbuild/protovalidate","Ref":"refs/tags/v0.1.5","Hash":"9c8e723aa8d7d34c72701585e3da2323203d4e85"}}%                              

@rodaine rodaine requested a review from akshayjshah June 1, 2023 20:29
@akshayjshah
Copy link

I think - but am not 100% sure - that the module proxy only re-parses the go.mod file when you cut a new release. Even if you retract all previous versions, you'll still have live docs for the new release. My memories of this are a bit hazy, but I think we need to proactively retract the version we're about to tag and release (I assume that'll be 0.1.6 or 0.2.0).

This system is...not user-friendly.

@rodaine
Copy link
Member Author

rodaine commented Jun 1, 2023

Added the next version we'd release for this. Hopefully this does the trick 🤞🏽

@rodaine rodaine merged commit e2564fe into main Jun 1, 2023
@rodaine rodaine deleted the rodaine/retract-erroneous-go-module-versions branch June 1, 2023 20:52
igor-tsiglyar pushed a commit to igor-tsiglyar/protovalidate that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments