Add more predefined rules conformance tests around repeated fields#258
Merged
Add more predefined rules conformance tests around repeated fields#258
Conversation
ghost
requested a review
from 
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
ghost
mentioned this pull request
1 task
rodaine
changed the title
rodaine
approved these changes
Oct 2, 2024
ghost
pushed a commit
to bufbuild/protovalidate-go
that referenced
this pull request
Oct 4, 2024
- [x] Update protovalidate conformance version once bufbuild/protovalidate#258 is merged+released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uncovers a minor bug in predefined rules on repeated fields that will need to be fixed in protovalidate-go.