Conversation
added 2 commits
January 30, 2025 21:20
- New workflow to create release tag (Yes I know, but it seemed trivial enough to add.) - New workflow to create draft release - BCR release prep script, adds Bazel snippets to release notes like other Bazel projects, creates stable release tarball
ghost
requested a review
from 
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
nicksnyder
reviewed
Jan 31, 2025
Member
nicksnyder
left a comment
nicksnyder
left a comment
There was a problem hiding this comment.
Can you add a RELEASING.md or equivalent to document the steps to take to do a release. e.g.
1. Go here (link) to start this workflow and wait for it to complete.
2. Go to https://github.com/bufbuild/protovalidate/releases to find the draft release that was just created.
4. Edit release notes if necessary.
5. Publish the release.
6. Check to see that a PR was created on [bazel-central-registry](https://github.com/bazelbuild/bazel-central-registry/pulls?q=is%3Apr+is%3Aopen+protovalidate)| ARCHIVE="${PREFIX}.tar.gz" | ||
|
|
||
| # Update MODULE.bazel version | ||
| >&2 echo "# Update MODULE.bazel version to ${TAG:1}" |
Member
There was a problem hiding this comment.
why are we redirecting all output to stderr?
Author
There was a problem hiding this comment.
Not any specific reason, I just tend to use stderr for logging and stdout for results, so I tend to do this without really thinking much.
Author
|
Added a |
nicksnyder
approved these changes
Jan 31, 2025
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should take care of the issues we have with the BCR publishing process, I think.