Skip to content

Refactor LT/GT into a oneof#76

Merged
elliotmjackson merged 4 commits intomainfrom
ejackson/refactor-lt-gt
Aug 22, 2023
Merged

Refactor LT/GT into a oneof#76
elliotmjackson merged 4 commits intomainfrom
ejackson/refactor-lt-gt

Conversation

@elliotmjackson
Copy link
Contributor

@elliotmjackson elliotmjackson commented Aug 22, 2023

relates to #77

In the given changes to the file "proto/protovalidate/buf/validate/validate.proto", several modifications have been made to the message definitions. The following actions were taken:

  • Previously existing oneof fields "_gt", "_gte", "_lt", and "_lte" were removed from messages like "FloatRules," "DoubleRules," "Int32Rules," and so on.
  • Fields within these messages were restructured: fields originally associated with "_lt" and "_lte" were moved to the "less_than" oneof, and fields originally associated with "_gt" and "_gte" were moved to the "greater_than" oneof.
  • Furthermore, certain fields originally associated with "_lt_now" were moved to the "less_than" oneof, and fields associated with "_gt_now" were moved to the "greater_than" oneof.

@elliotmjackson elliotmjackson marked this pull request as ready for review August 22, 2023 17:59
@elliotmjackson elliotmjackson merged commit d61466d into main Aug 22, 2023
@elliotmjackson elliotmjackson deleted the ejackson/refactor-lt-gt branch August 22, 2023 18:11
igor-tsiglyar pushed a commit to igor-tsiglyar/protovalidate that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments