Write logs according the verbosity level defined #11
Conversation
There was a problem hiding this comment.
Hey @erickhun, thanks for this work 🌮
I think monolog already supports this feature. If I am not mistaken we could configure it by passing it as the second parameter to the StreamHandler constructor:
$logLevelFromEnv = getenv(self::$logLevelEnvVar);
$handler = new StreamHandler('php://stdout', $logLevelFromEnv);I may be missing some context on the requirements as there may be good reasons to build our own. If that's the case, this implementation LGTM 👍 I left a couple of small comments below. Nothing blocking!
src/BuffLog/BuffLog.php
Outdated
| $logLevelFromEnv = getenv(self::$logLevelEnvVar); | ||
| $monologLevels = self::getLogger()->getLevels(); |
There was a problem hiding this comment.
We could slide this two lines out and pass $logLevel to the setVerbosityLevel as an argument. That way this method becomes a setter that could be used to configure the verbosity level in user land. I don't think that's going to happen very often, though.
src/BuffLog/BuffLog.php
Outdated
| // Optimization: we could move this at the singleton initialization | ||
| self::setVerbosityLevel(); |
There was a problem hiding this comment.
:plus-one: to that optimization comment 👍
|
@esclapes oh wow , great spot, I didn't spot that feature 🙈 This will greatly simplify the code 🤩. Let me rework the code and loop you again with this |
|
@esclapes I've reworked the code with using the |
This PR will :
LOG_LEVELin the env variableNOTICElevelI use Monolog levels for now until we decide the final ones
@colinscape @esclapes Can I have your eyes on this ?