This repository was archived by the owner on Jun 9, 2023. It is now read-only.
Use transient prop on Button to fix console warning#284
Merged
Conversation
albennett
reviewed
Feb 10, 2021
| type={type} | ||
| fullWidth={fullWidth} | ||
| loading={loading} | ||
| $loading={loading} |
Contributor
There was a problem hiding this comment.
Ooh, haven't seen this before!
So, we're currently using a beta version of the ui library because there were react mismatch issues. Hopefully the beta will get published soon (it's waiting on cross-team PR reviews) 🤞 In the meantime, any non-beta versions will break publish. It may make sense to wait until it gets published before doing this change.
Contributor
Author
There was a problem hiding this comment.
Yeah, no rush TBH. Thanks for the ⏩ review though. 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the
loadingprop transient so that React doesn't try putting it in the DOM.I noticed this showing a warning in Publish because it was trying to pass through:

Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: