fix: enforce exact sanitized permissions after extraction, bypassing umask#101
Merged
fix: enforce exact sanitized permissions after extraction, bypassing umask#101
Conversation
…umask `create_file_with_mode` used `OpenOptions::mode()` which is subject to the process umask. A typical umask of 022 would silently strip group-write bits, causing sanitized mode 0o775 to land as 0o755. After opening the file, call `fs::set_permissions` with the intended mode to override umask and enforce the exact sanitized permissions. Closes #97
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_file_with_modecalledOpenOptions::mode()which is subject to the process umask (typically022), silently stripping group-write bits — sanitized mode0o775would land as0o755fs::set_permissions(path, Permissions::from_mode(m))to enforce the exact sanitized mode, bypassing umasktest_create_file_with_mode_bypasses_strict_umask) that explicitly sets umask to0o077to directly validate the bypassCloses #97
Test plan
cargo +nightly fmt --all -- --check— passescargo clippy --all-targets --all-features --workspace -- -D warnings— passesRUSTDOCFLAGS="-D warnings" cargo doc --no-deps --all-features --workspace— passescargo nextest run --workspace --all-features --exclude exarch-python --exclude exarch-node --lib --bins— 534/534 passcargo deny check— passes