feat: auto-create destination directory on extract#102
Merged
Conversation
If the destination directory does not exist, create it (including all intermediate directories) before extraction begins, matching the behavior of tar, unzip, and 7z. Adds DestDir::new_or_create() which calls create_dir_all then delegates to DestDir::new() for existing validation. All three format extractors (tar, zip, sevenz) updated to use the new constructor. Closes #78
bug-ops
force-pushed
the
auto-create-dest-dir
branch
from
0f18201 to
14cbb39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DestDir::new_or_create()that callscreate_dir_allbefore delegating toDestDir::new()for validationtar -C,unzip -d, and7z x -oTest plan
dest_dir.rs: nonexistent dir, nested path, existing dir, file-not-dir conflict, unwritable parentcargo nextest run)Closes #78