test: add CVE-2025-29787 regression test (ZIP symlink zip-slip)#138
Merged
test: add CVE-2025-29787 regression test (ZIP symlink zip-slip)#138
Conversation
exarch is not vulnerable: SafeSymlink::validate rejects escaping symlinks (e.g. `up -> ../..`) before they are written to disk, so a subsequent entry `up/etc/passwd` can never escape the extraction root. Adds two regression tests in cve_regression.rs: - zip slip blocked with allow_symlinks=true (unix): asserts SymlinkEscape error - zip slip blocked with allow_symlinks=false (default): asserts SecurityViolation Closes #133
bug-ops
force-pushed
the
133-zip-symlink-cve-regression
branch
from
8a52f43 to
7f15ca0
Compare
github-actions
bot
added
core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SafeSymlink::validaterejects escaping symlinks before they are written to disk, so a subsequent entryup/etc/passwdcan never escape the extraction rootcrates/exarch-core/tests/security/cve_regression.rs:test_cve_2025_29787_zip_slip_blocked_with_symlinks_enabled(unix): assertsSymlinkEscapeerror and verifies no file escaped extraction roottest_cve_2025_29787_zip_slip_blocked_with_symlinks_disabled: assertsSecurityViolationat the symlink entry with default configtests/cve/cve_2025_29787.rsfollowing existing workspace CVE patternTest plan
cargo nextest runpasses (615 tests, 3 skipped)cargo clippy --all-targets --all-features --workspace -- -D warningscleancargo +nightly fmt --all -- --checkcleanRUSTDOCFLAGS="-D warnings" cargo doccleancargo deny checkcleanCloses #133