fix: honor --force flag in extract subcommand#88
Merged
Conversation
Without --force, extraction now fails with a clear error listing conflicting destination files. With --force, existing files are silently overwritten (previous behavior). Closes #77
github-actions
bot
added
core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--forceflag on theextractsubcommand was parsed by clap but never read, causing extraction to always overwrite silently--force, extraction now fails with a clear error listing conflicting destination files--force, existing files are silently overwritten (previous behavior preserved)Changes
crates/exarch-cli/src/commands/extract.rs: added pre-extraction conflict check usinglist_archivecrates/exarch-cli/tests/cli_tests.rs: added 2 integration tests covering both pathsCHANGELOG.md: updated [Unreleased]Test plan
cargo +nightly fmt --all -- --checkpassescargo clippy --all-targets --all-features --workspace -- -D warningspassesRUSTDOCFLAGS="-D warnings" cargo doc --no-deps --all-features --workspacepassescargo nextest run --workspace --all-features --exclude exarch-python --exclude exarch-node --lib --bins— 511 passed, 3 skipped--forceto conflicting destination → fails with actionable error--forceto conflicting destination → succeedsCloses #77