fix: strip world-writable bit; add --allow-world-writable flag#94
Merged
fix: strip world-writable bit; add --allow-world-writable flag#94
Conversation
World-writable files (mode 0o777) aborted extraction with an error, while setuid/setgid bits were silently stripped. Make behavior consistent: strip the world-writable bit (0o002) by default, and add `--allow-world-writable` CLI flag / `allow_world_writable` SecurityConfig option for explicit opt-in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84.
Summary
0o777) aborted extraction with an error, while setuid/setgid bits were silently stripped — inconsistent behavior0o002) by default, consistent with existing setuid/setgid stripping--allow-world-writableCLI flag andallow_world_writable: boolinSecurityConfig.allowedfor explicit opt-inChanges
crates/exarch-core/src/security/permissions.rs: replaceErr(InvalidPermissions)withsanitized &= !0o002strip; addtest_world_writable_allowed_with_config,test_world_writable_stripped_by_default,test_world_writable_bit_only_strippedcrates/exarch-cli/src/cli.rs: add--allow-world-writableflag toExtractArgscrates/exarch-cli/src/commands/extract.rs: wire flag toallowed.world_writableCHANGELOG.md: document fix and new flag under[Unreleased]Test plan
cargo +nightly fmt --all -- --checkpassescargo clippy --all-targets --all-features --workspace -- -D warningspassescargo nextest run --workspace --all-features --exclude exarch-python --exclude exarch-node --lib --bins— 516 tests passtest_sanitize_permissions_strip_world_writablenow assertsOk(0o775)instead of errorallow_world_writable = truepreserves bit;0o666 → 0o664(only other-write stripped)