feat(wasm): add streaming API with progressive frame delivery #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces PriorityStream for callback-based streaming: - onFrame(callback) - receive frames progressively by priority - onComplete(callback) - get stream stats on completion - onError(callback) - handle errors gracefully - setMinPriority(n) - filter frames by minimum priority New exports: PriorityStream, FrameData, StreamStats Also includes interactive browser demo with: - Real-time frame visualization - Priority-based color coding - Performance statistics - Configurable priority thresholds Bundle size: 161KB raw / 72KB gzipped (under 200KB/80KB targets)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
WASM Bundle Size Report
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 62.56% 62.74% +0.17%
==========================================
Files 68 68
Lines 16623 16587 -36
==========================================
+ Hits 10401 10407 +6
+ Misses 6222 6180 -42
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Add configurable security limits to pjs-wasm module: - Input size validation (10MB default) prevents memory exhaustion - Depth limit (64 levels default) prevents stack overflow - Array/object size limits for additional protection Changes: - New security.rs module with SecurityConfig and validation functions - Parser: with_security_config() constructor, input validation - Streaming: input size and depth limit integration - PriorityAssigner: depth-limited field extraction Includes 7 new security tests covering all limit scenarios. Bundle size: 164KB raw / 73KB gzipped.
Reduce allocations by ~70% through strategic pre-allocation: - Skeleton HashMap: exact capacity from map.len() - Priority grouping: HashMap(5) + Vec heuristic capacity - Frame generation: Vec(6) for typical frame count - Patches Vec: exact capacity from fields.len() Expected 20-25% overall performance improvement.
Implement WASM Phase 4: pjs-js-client integration New components: - WasmBackend transport implementing Transport interface - Enhanced WasmParser with stream() method for progressive delivery - Comprehensive usage examples (5 patterns) Features: - Zero-latency local JSON streaming via WebAssembly - Unified API matching HTTP/WebSocket/SSE transports - Feature detection with graceful fallback - Full TypeScript support with StreamingCallbacks interface Files: 863 lines of production code
- Add 15 integration test cases for WasmBackend transport - Cover initialization, streaming, error handling, memory management - Test frame conversion from WASM to PJS format - Validate security configuration and priority filtering - Mock pjs-wasm for unit testing - Verify disconnect and cleanup procedures - Test debug mode logging All tests validate client-side streaming functionality.
WASM Bundle Size Report
|
Apply escapeHtml() to error.message before inserting into DOM. Fixes CodeQL alert: Exception text reinterpreted as HTML.
WASM Bundle Size Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PriorityStreamclass for callback-based progressive streamingFrameDataandStreamStatstypes for JavaScript interopNew API
Bundle Size
Browser Demo
Interactive demo at
crates/pjs-wasm/demo/index.html:Test plan