-
Notifications
You must be signed in to change notification settings - Fork 2
Closed
Labels
architectureArchitecture improvementsArchitecture improvementsllmzeph-llm crate (Ollama, Claude)zeph-llm crate (Ollama, Claude)
Description
Epic: #1977
LLM providers use inconsistent construction patterns:
- ClaudeProvider::new(api_key, model, max_tokens) — 3 args
- OpenAiProvider::new(api_key, base_url, model, max_tokens, embed_model, reasoning) — 6 args
- GeminiProvider::new(api_key, model, max_tokens) — 3 args
- OllamaProvider::new(base_url) — 1 arg
Standardize on builder pattern for providers with 4+ constructor args.
Acceptance Criteria:
- OpenAiProvider uses builder pattern
- No other provider has > 4 positional constructor args
- All tests pass
Complexity: Small | Effort: 1h
Ref: ABS-08
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
architectureArchitecture improvementsArchitecture improvementsllmzeph-llm crate (Ollama, Claude)zeph-llm crate (Ollama, Claude)