Conversation
…owed_tools, background auto-deny - Add PermissionMode enum (default/accept_edits/dont_ask/bypass_permissions/plan) to SubAgentPermissions; BypassPermissions emits tracing::warn at parse time - Add tools.except denylist in YAML frontmatter → SubAgentDef.disallowed_tools; deny wins over allow-list; consistent placement under tools: section (IMP-02) - FilteredToolExecutor::with_disallowed() checks disallowed list before ToolPolicy - PlanModeExecutor: exposes real tool catalog, blocks all execution (IMP-01) - Background agents auto-deny secret requests inline without blocking on channel (CRIT-01) - SubAgentConfig gets default_permission_mode and default_disallowed_tools globals - Re-export PermissionMode and PlanModeExecutor from subagent public API - Update config snapshot, fix test fixtures in agent/mod.rs - +22 tests (zeph-core lib: 884 → 906), workspace: 3447 passed
… add serde asymmetry note - SEC-P2-04: upgrade background secret auto-deny log from debug to warn - IMP-CRIT-04: add doc comment explaining disallowed_tools serde asymmetry (deserialized from tools.except, serialized as flat disallowed_tools)
github-actions
bot
added
enhancement
This was
linked to
issues
Mar 4, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1180, #1181, #1183, #1184, #1185. Partially closes #1186.
Addresses #1182.
Summary
default_permission_modeanddefault_disallowed_toolsfromSubAgentConfigat spawn time; per-agent settings take precedence over config defaults (feat(subagents): apply default_permission_mode and default_disallowed_tools at spawn time #1180)allow_bypass_permissions: bool(default: false) toSubAgentConfig; spawning an agent withbypass_permissionsmode is rejected with an error unless the gate is enabled (sec(subagents): bypass_permissions mode needs config-level allowlist gate #1182)#[serde(deny_unknown_fields)]toRawSubAgentDef; YAML typos in top-level keys now return a parse error instead of being silently ignored (sec(subagents): add #[serde(deny_unknown_fields)] to RawSubAgentDef #1183)filter.rsexplaining exact-string tool ID matching and MCP compound IDs (sec(subagents): disallowed_tools exact string match does not block compound MCP tool IDs #1181)disallowed_toolsfiltered fromPlanModeExecutortool catalog (test(subagents): add test for disallowed_tools filtered from PlanModeExecutor catalog #1184)Test plan
cargo +nightly fmt --checkcargo clippy --workspace -- -D warningscargo nextest run --workspace --lib --bins— 3459/3459 passed (+12 tests)