fix(core): validate model name in /model command against provider list#1445
Merged
fix(core): validate model name in /model command against provider list#1445
Conversation
#1417) The /model command now checks the provided model ID against the cached model list before applying it. Unknown models are rejected with an error listing available options. When the model list is unavailable (cold start or provider without listing support), a warning is shown and the switch proceeds to preserve backward compatibility. Fixes #1417
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/model <id>now validates the provided model name against the cached provider model list before applying itChanges
crates/zeph-core/src/agent/mod.rs: validation inhandle_model_command()— cache-first, remote fallback, early return on unknown modelcrates/zeph-llm/src/mock.rs:MockProvidergains optionalmodelsfield andwith_models()builder for test injectioncrates/zeph-llm/src/any.rs:AnyProvider::Mockreturns injected models fromlist_models_remote(); doc comment updatedTest plan
cargo +nightly fmt --checkcleancargo clippy --workspace --features full -- -D warningscleancargo nextest run --workspace --features full --lib --bins— 4872 passedFixes #1417