fix(security): truncate SecretRequest.reason in confirmation prompt#1482
Merged
fix(security): truncate SecretRequest.reason in confirmation prompt#1482
Conversation
…1456) Embed reason via `text::truncate_to_chars(r, 200)` instead of verbatim to prevent a malicious sub-agent from flooding the terminal or Telegram message with an arbitrarily long reason string. Adds 5 unit tests covering ASCII, exact boundary, over-limit, multi-byte UTF-8 (Cyrillic), and None reason cases. Closes #1456
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SecretRequest.reasonviatext::truncate_to_chars(r, 200)instead of verbatim in the user-facing confirmation promptChanges
crates/zeph-core/src/agent/mod.rs: usecrate::text::truncate_to_chars(r, 200)inprocess_pending_secret_requests()Nonereason casesCHANGELOG.md: entry added to[Unreleased] ### FixedFollow-up
secret_keyhas no length bound in the same prompt (pre-existing, low severity)Closes #1456