fix(acp): apply graph memory config to ACP sessions#1645
Merged
Conversation
github-actions
bot
added
documentation
`spawn_acp_agent` was not calling `agent.with_graph_config()`, so the
`graph_config` field in `MemoryState` always defaulted to
`GraphConfig { enabled: false }`. The guard in
`maybe_spawn_graph_extraction()` returned early on every turn,
silently disabling graph extraction for all ACP-connected clients
(Zed, Helix, VS Code) regardless of `[memory.graph] enabled = true`
in the user's config.
Add `graph_config: GraphConfig` to `SharedAgentDeps`, populate it from
`config.memory.graph` at startup, and apply it in `spawn_acp_agent`
after the `with_memory` call — matching the existing pattern in
`src/runner.rs` and `src/daemon.rs`.
Closes #1633.
bug-ops
force-pushed
the
fix-acp-graph-memory-config-no
branch
from
f013186 to
783bc5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
graph_config: GraphConfigfield toSharedAgentDepsinsrc/acp.rsconfig.memory.graphat startup alongside other config fieldsagent.with_graph_config(graph_config)inspawn_acp_agentafterwith_memory, matching the existing pattern insrc/runner.rs:827andsrc/daemon.rs:368Closes #1633.
Root Cause
spawn_acp_agentwas missing thewith_graph_config()call, soMemoryState.graph_configalways heldGraphConfig::default()which hasenabled = false. The guard inmaybe_spawn_graph_extraction()returned early on every assistant response, silently disabling graph extraction for all ACP sessions (Zed, Helix, VS Code) regardless of[memory.graph] enabled = truein config.Test plan
cargo nextest run --workspace --features full --lib --bins)cargo clippy --workspace --features full -- -D warningspassescargo +nightly fmt --checkpasses[memory.graph] enabled = true, send prompts with named entities, confirm rows appear ingraph_entitiestable within ~35s