feat(gemini): document SSE functionCall gap with TODO for Phase 4#1660
Merged
feat(gemini): document SSE functionCall gap with TODO for Phase 4#1660
Conversation
GeminiStreamPart in sse.rs has no function_call field, so functionCall chunks are silently dropped when Gemini streams tool calls via SSE. chat_with_tools() uses the non-streaming endpoint today, so behavior is correct. Added a TODO comment (referencing #1659) at the drop site to ensure Phase 4 (SSE streaming tool use) addresses this before enabling the streaming path for tool-use sessions. Closes #1639.
github-actions
bot
added
enhancement
bug-ops
force-pushed
the
feat-gemini-sse-streaming-path
branch
from
7532063 to
d48ad5f
Compare
bug-ops
force-pushed
the
feat-gemini-sse-streaming-path
branch
from
d48ad5f to
8ad2268
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_gemini_sse_event()(crates/zeph-llm/src/sse.rs) documenting thatGeminiStreamPartlacks afunction_callfield and thatfunctionCallSSE chunks are silently dropped.chat_with_tools()currently uses the non-streaming endpoint, so this is safe — the TODO is purely a forward-looking marker for Phase 4.Test plan
cargo +nightly fmt --checkpassescargo clippy --workspace --features full -- -D warningspasses (0 warnings)cargo nextest run --config-file .github/nextest.toml --workspace --features full --lib --binspasses (5236 tests)Closes #1639.