fix(acp): invert slash command routing to allowlist approach#1679
Merged
fix(acp): invert slash command routing to allowlist approach#1679
Conversation
github-actions
bot
added
bug
Only ACP-native commands (/help, /model, /mode, /clear, /review) are intercepted by handle_prompt(); all other slash commands are forwarded to the agent loop unchanged. Removes the denylist/pass-through pattern that blocked /plan, /graph, /status, /skills, /scheduler, /compact, etc.
bug-ops
force-pushed
the
fix/acp-agent-loop-slash-commands
branch
from
9b5d08e to
b02b1a7
Compare
This was referenced Mar 13, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handle_prompt()with an allowlist: only the 5 ACP-native commands (/help,/model,/mode,/clear,/review) are intercepted; everything else is forwarded to the agent loop unchangedslash_command_pass_throughhelper function entirely/plan,/graph,/status,/skills,/scheduler,/compact, and all future agent-loop commands in ACP sessionsCloses #1672
Test plan
slash_unknown_command_forwarded_to_agent_loop— unknown commands reach the agent loopacp_native_commands_are_intercepted—/help,/help foo,/model,/model foo,/mode,/mode bar,/clear,/reviewall interceptedagent_loop_commands_are_not_intercepted—/plan,/graph,/status,/skills,/scheduler,/compact,/unknownall pass throughslash_help_with_args_returns_end_turn— async integration test for/help foocargo nextest run -p zeph-acp— 314 tests pass